Revert PR #15#21
Merged
Merged
Conversation
Member
|
Double checked the impact of the changes in #15 by running diff --git a/pom.xml b/pom.xml
index ddc14bf349..3fed6a3e6b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -52,7 +52,7 @@
<kryo.version>2.24.0</kryo.version>
<testng.version>6.8</testng.version>
<guava.version>17.0</guava.version>
- <ome-common.version>5.3.2</ome-common.version>
+ <ome-common.version>5.3.3</ome-common.version>
<ome-model.version>5.5.4</ome-model.version>
<ome-poi.version>5.3.1</ome-poi.version>
<ome-mdbtools.version>5.3.0</ome-mdbtools.version>and verifying the TIFF writing unit tests fail. diff --git a/pom.xml b/pom.xml
index ddc14bf349..3fed6a3e6b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -52,7 +52,7 @@
<kryo.version>2.24.0</kryo.version>
<testng.version>6.8</testng.version>
<guava.version>17.0</guava.version>
- <ome-common.version>5.3.3</ome-common.version>
+ <ome-common.version>5.3.4-SNAPSHOT</ome-common.version>
<ome-model.version>5.5.4</ome-model.version>
<ome-poi.version>5.3.1</ome-poi.version>
<ome-mdbtools.version>5.3.0</ome-mdbtools.version>All unit tests pass as expected. The diff of this repo since Pushed 409e34c to document these changes in the top-level NEWS file. Once the last commit is approved by @melissalinkert, I will merge and release |
sbesson
approved these changes
Jan 4, 2018
Member
Author
|
Last commit looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #15 and https://trello.com/c/OimiHAQY/5-profile-tiff-writing-on-windows
Merging this should bring master back into a state that is usable by Bio-Formats.